Skip to content

Trello card: Added Kubernetes Storage Metrics via Prometheus section #7579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from Feb 13, 2018
Merged

Trello card: Added Kubernetes Storage Metrics via Prometheus section #7579

1 commit merged into from Feb 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 5, 2018

@ghost ghost added branch/enterprise-3.7 branch/enterprise-3.9 peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 5, 2018
@ghost ghost added this to the Next Release milestone Feb 5, 2018
@ghost ghost self-assigned this Feb 5, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2018
This section describes the desired metrics to be emitted from Kubernete's storage subsystem. These metrics are not currently emitted by the system, but
they can help to identify the health of the storage subsystem and cluster.

.Desired Metrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add Desired metrics section here. It was present in original Google doc for data collection.

@@ -1031,6 +1035,254 @@ Once `openshift_metrics_project: openshift-infra` is installed, metrics can be
gathered from the `http://${POD_IP}:7575/metrics` endpoint.
====

[[openshift-prometheus-kubernetes-metrics]]
=== Kubernetes Storage Metrics via Prometheus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use word {{product-title}} rather than hardcoding Kubernetes or Openshift everywhere

Copy link
Author

@ghost ghost Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have an attribute for Kubernetes. The {product-title} attribute is only defined for OpenShift distros.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant renamed "Kubernetes Storage metrics" to "Openshift storage metrics"

@ghost
Copy link
Author

ghost commented Feb 7, 2018

@gnufied Changes made, PTAL.

@ghost
Copy link
Author

ghost commented Feb 7, 2018

[rev_history]
|xref:../install_config/cluster_metrics.adoc#openshift-prometheus[Enabling Cluster Metrics -> Prometheus on OpenShift Container Platform]
|Added the xref:../install_config/cluster_metrics.adoc#openshift-prometheus-kubernetes-metrics[Kubernetes Storage Metrics via Prometheus] section.
%

@ghost
Copy link
Author

ghost commented Feb 12, 2018

@openshift/team-documentation PTAL. Rev history in the previous comment.

@@ -37,6 +37,10 @@ each node individually through the `/stats` endpoint. From there, Heapster
scrapes the metrics for CPU, memory and network usage, then exports them into
Hawkular Metrics.

The storage volume metrics available on the kubelet are not available through
the `/stats` endpoint, but are available through the ``/metrics` endpoint. See

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double backtick at the start of the /metrics bit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

These metrics report time taken by a storage operation once started. These
metrics keep track of operation time at the plug-in level, but do not include
time taken by `goroutine` to run or operation to be picked up from the internal
queue. These metrics are of type histogram.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Histogram is in ""s above. Should this one too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@bfallonf
Copy link

@tmorriso-rh A couple comments. LG otherwise 🚃

@ghost ghost merged commit 6391aa4 into openshift:master Feb 13, 2018
@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.9-stage

@openshift-cherrypick-robot

@tmorriso-rh: new pull request created: #7768

In response to this:

/cherrypick enterprise-3.9-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost ghost added peer-review-done Signifies that the peer review team has reviewed this PR and removed branch/enterprise-3.7 peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 14, 2018
@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging, Published - 02/16/2018 Feb 16, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.9 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants