-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Trello card: Added Kubernetes Storage Metrics via Prometheus section #7579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
install_config/cluster_metrics.adoc
Outdated
This section describes the desired metrics to be emitted from Kubernete's storage subsystem. These metrics are not currently emitted by the system, but | ||
they can help to identify the health of the storage subsystem and cluster. | ||
|
||
.Desired Metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to add Desired metrics section here. It was present in original Google doc for data collection.
install_config/cluster_metrics.adoc
Outdated
@@ -1031,6 +1035,254 @@ Once `openshift_metrics_project: openshift-infra` is installed, metrics can be | |||
gathered from the `http://${POD_IP}:7575/metrics` endpoint. | |||
==== | |||
|
|||
[[openshift-prometheus-kubernetes-metrics]] | |||
=== Kubernetes Storage Metrics via Prometheus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use word {{product-title}} rather than hardcoding Kubernetes or Openshift everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have an attribute for Kubernetes. The {product-title} attribute is only defined for OpenShift distros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant renamed "Kubernetes Storage metrics" to "Openshift storage metrics"
@gnufied Changes made, PTAL. |
[rev_history] |
@openshift/team-documentation PTAL. Rev history in the previous comment. |
install_config/cluster_metrics.adoc
Outdated
@@ -37,6 +37,10 @@ each node individually through the `/stats` endpoint. From there, Heapster | |||
scrapes the metrics for CPU, memory and network usage, then exports them into | |||
Hawkular Metrics. | |||
|
|||
The storage volume metrics available on the kubelet are not available through | |||
the `/stats` endpoint, but are available through the ``/metrics` endpoint. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double backtick at the start of the /metrics bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
install_config/cluster_metrics.adoc
Outdated
These metrics report time taken by a storage operation once started. These | ||
metrics keep track of operation time at the plug-in level, but do not include | ||
time taken by `goroutine` to run or operation to be picked up from the internal | ||
queue. These metrics are of type histogram. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Histogram is in ""s above. Should this one too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@tmorriso-rh A couple comments. LG otherwise 🚃 |
/cherrypick enterprise-3.9-stage |
@tmorriso-rh: new pull request created: #7768 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Trello card: https://trello.com/c/J58JYpOl/714-document-cm-ops-tools-storage-prometheus-endpoint-coverage